Consolidation of solve groups and vectors in blocks (part 1/X)#742
Merged
landinjm merged 14 commits intoprisms-center:masterfrom Dec 3, 2025
Merged
Consolidation of solve groups and vectors in blocks (part 1/X)#742landinjm merged 14 commits intoprisms-center:masterfrom
landinjm merged 14 commits intoprisms-center:masterfrom
Conversation
fractalsbyx
pushed a commit
to fractalsbyx/phaseField
that referenced
this pull request
Dec 11, 2025
…s-center#742) * basic enum and vector mapping class start * updating the TensorRank enum throughout * updating apps * fixing some warnings * shadowed variables name in matrix free operator * more variable shadowing * fix to unit test * more shadowed var * more shadows * more shadows * some more fixes for warnings * typo * disable wconversion * adding cppcheck suppression comments
fractalsbyx
pushed a commit
to fractalsbyx/phaseField
that referenced
this pull request
Dec 11, 2025
…s-center#742) * basic enum and vector mapping class start * updating the TensorRank enum throughout * updating apps * fixing some warnings * shadowed variables name in matrix free operator * more variable shadowing * fix to unit test * more shadowed var * more shadows * more shadows * some more fixes for warnings * typo * disable wconversion * adding cppcheck suppression comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
What I originally designed with
SolutionHandleris becoming unwieldy to debug and frankly difficult to work with. We've talked about this offline before and this PR is a start to consolidating what we have.At the end of everything, this PR chain should address #730, #729, #727, #725, #724, #710, #701, #680, #676, , #674, #632, #627, #612, #611, #504, #503, #502, #721, #484, #483, #434.
This PR
For this PR, all I aim to do is create the class and associated data structures that we be used in the block vectors and organization of our solution fields. This requires some rewriting/refactoring of
VariableAttributesto extract a small enum that is useful for the vector blocks.Additionally, this new class eliminates the need to have a bunch of confusing maps and access to
SolutionHandler.