Fix the gradient energy calculation#770
Merged
landinjm merged 2 commits intoprisms-center:masterfrom Jan 12, 2026
Merged
Conversation
Contributor
|
Update the regression test outputs, and this will be good to go. |
Contributor
Author
|
gold_output.txt updated |
landinjm
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fix the gradient energy calculation for a scalar gradient coefficient. This fixes Gradient energy calculation seems wrong #769.
What is the current behavior? (You can also link to an open issue here)
See Gradient energy calculation seems wrong #769
What is the new behavior (if this is a feature change)?
See Gradient energy calculation seems wrong #769
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
I did a search with
\[i\][a-zA-Z0-9 +*-]{1,20}\[j\];