Skip to content

Allow initial conditions to be set via files OR programmatically#818

Merged
landinjm merged 3 commits intoprisms-center:masterfrom
mythreyiramesh:mixmatchic
Feb 19, 2026
Merged

Allow initial conditions to be set via files OR programmatically#818
landinjm merged 3 commits intoprisms-center:masterfrom
mythreyiramesh:mixmatchic

Conversation

@mythreyiramesh
Copy link
Copy Markdown
Contributor

@mythreyiramesh mythreyiramesh commented Feb 18, 2026

  • Please check if the PR fulfills these requirements
  • The PR follows our guidelines (formatting & style)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix that lets mixing and matching of initial conditions

  • What is the current behavior? (You can also link to an open issue here)
    Cannot mix and match initial conditions between file-read and programatic (this PR fixes Can't mix-and-match initial conditions between file-read and programatic #795)

  • What is the new behavior (if this is a feature change)?
    set read initial conditions from file is now unnecessary. The specified initial condition files are parsed to obtain the list of variables for which files are specified. If file isn't specified, initial condition is set programmatically.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:
    We may have to phase out set read initial conditions from file

@landinjm landinjm added this pull request to the merge queue Feb 19, 2026
Merged via the queue into prisms-center:master with commit 7adb5aa Feb 19, 2026
3 checks passed
landinjm pushed a commit that referenced this pull request Apr 9, 2026
* chunked binary read

* port Mythreyi's PR818 to 4.0 to allow reading IC from both file and program
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't mix-and-match initial conditions between file-read and programatic

2 participants