Skip to content

Conversation

@Chaitanya1672
Copy link
Contributor

@Chaitanya1672 Chaitanya1672 commented Jun 14, 2024

Progress towards #3163

Changes:
I have added the beginClip() and endClip() functions to the p5FunctionKeywords to ensure they are highlighted like other p5.js functions in the p5.js web editor.
image

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@raclim raclim added Type:Task Tasks tied specifically to developer operations and maintenance Priority:Medium Moderately important, should be completed in a fair timeframe Bug Error or unexpected behaviors labels Jun 16, 2024
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this! Despite being a temporary resolution to the issue, I'm going to merge this in as progress towards it to get this out there since this overall is a beneficial change. Thanks again and please feel free to open another PR with the long-term fix!

@raclim raclim merged commit 1016389 into processing:develop Jun 24, 2024
@Chaitanya1672 Chaitanya1672 deleted the fix/keyword-syntax-highlighting-beginClip branch June 25, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Error or unexpected behaviors Priority:Medium Moderately important, should be completed in a fair timeframe Type:Task Tasks tied specifically to developer operations and maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants