Fix to#7984 #8014
Merged
Fix to#7984 #8014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
Contributor
|
This is looking good! We have some existing alignment tests in https://github.com/processing/p5.js/blob/dev-2.0/test/unit/visual/cases/typography.js, do you think we could add a test case for the situation that was breaking before so that we don't accidentally lose this behaviour when refactoring in the future? |
Member
|
Thank you @dhowe ! |
Contributor
Author
|
@ksen0 I've added the relevant tests - do we need anything else to get this merged in ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to horizontal and vertical alignment for manually-broken lines (issue #7984)