Skip to content

remove gcp HCS generators#550

Draft
maskarb wants to merge 1 commit intomainfrom
gcp-hcs
Draft

remove gcp HCS generators#550
maskarb wants to merge 1 commit intomainfrom
gcp-hcs

Conversation

@maskarb
Copy link
Copy Markdown
Contributor

@maskarb maskarb commented Apr 24, 2025

Summary by Sourcery

Chores:

  • Remove unused HCS generator from GCP generator list

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented Apr 24, 2025

Reviewer's Guide by Sourcery

This pull request removes the GCP HCS generator from the codebase by deleting its implementation file and references. The change ensures that the HCS generator is no longer included in GCP report generation.

Class diagram for removal of JSONLHCSGenerator from GCP generators

classDiagram
    class JSONLHCSGenerator {
        <<removed>>
        +generate()
        +other_methods()
    }
    class JSONLComputeEngineGenerator {
        +generate()
    }
    class JSONLGCPNetworkGenerator {
        +generate()
    }
    class JSONLGCPDatabaseGenerator {
        +generate()
    }
    class JSONLProjectGenerator {
        +__init__(account)
        +generate()
    }
    %% JSONLHCSGenerator is removed from the list of generators used in gcp_create_report
    note for JSONLHCSGenerator "This class and its usage have been removed from the codebase."
Loading

File-Level Changes

Change Details Files
Removed the GCP HCS generator from the report generation process.
  • Deleted the reference to the HCS generator from the list of GCP generators used in report creation.
  • Ensured that the HCS generator is no longer instantiated or used in the report logic.
nise/report.py
Deleted the implementation file for the GCP HCS generator.
  • Removed the hcs_generator.py file, eliminating the code for the HCS generator.
nise/generators/gcp/hcs_generator.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant