Skip to content

feat: prevent isos known to desync from queueing #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JLaferri merged 1 commit into from
Feb 20, 2026
Merged

feat: prevent isos known to desync from queueing #452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Externals/SlippiRustExtensions
Open in desktop
Submodule SlippiRustExtensions updated 5 files
+19 −0 ffi/includes/SlippiRustExtensions.h
+34 −2 ffi/src/exi.rs
+86 −25 game-reporter/src/iso_md5_hasher.rs
+18 −2 game-reporter/src/lib.rs
+13 −5 game-reporter/src/queue.rs
27 changes: 27 additions & 0 deletions Source/Core/Core/Slippi/SlippiMatchmaking.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,33 @@ void SlippiMatchmaking::startMatchmaking()
m_client = nullptr;

int retryCount = 0;

// If IsFixedRules mode, don't allow ISO's that are known to desync
if (IsFixedRulesMode(m_searchSettings.mode))
{
auto check = slprs_get_iso_md5_check(slprs_exi_device_ptr);
while (check.result == 0)
{
Common::SleepCurrentThread(500);
retryCount++;
if (retryCount > 10)
{
m_state = ProcessState::ERROR_ENCOUNTERED;
m_errorMsg = "Could not validate ISO";
return;
}
check = slprs_get_iso_md5_check(slprs_exi_device_ptr);
}

if (check.result == 2)
{
m_state = ProcessState::ERROR_ENCOUNTERED;
m_errorMsg = "Cannot queue for this mode with a modded ISO known to desync";
return;
}
}

retryCount = 0;
auto userInfo = m_user->GetUserInfo();
while (m_client == nullptr && retryCount < 15)
{
Expand Down
Loading