feat: Implement api key management#403
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #403 +/- ##
==========================================
- Coverage 88.77% 82.82% -5.95%
==========================================
Files 56 62 +6
Lines 1737 1875 +138
Branches 457 483 +26
==========================================
+ Hits 1542 1553 +11
- Misses 184 311 +127
Partials 11 11 ☔ View full report in Codecov by Sentry. |
688b58c to
9eff2a6
Compare
|
The option to create API keys should depend on zot configuration, I opened a PR to add this configuration to the results returned by the mgmt API, see project-zot/zot#2138 |
|
Also, refresh doesn't seem to work on the API key page, I get 404 on refresh |
@raulkele the PR I mentioned has been merged, now you can check if the API Keys are enabled using the mgmt API, same as the other auth settings. |
8866d06 to
3a6b7a0
Compare
|
@andaaron updated the PR to match the api key config setting returned by the mgmt endpoint. |
Signed-off-by: Raul-Cristian Kele <raulkeleblk@gmail.com>
3a6b7a0 to
3c38005
Compare
andaaron
left a comment
There was a problem hiding this comment.
Looks good, also tested the changes manually.
See Raul's PR: project-zot/zui#403 Signed-off-by: Andrei Aaron <aaaron@luxoft.com>
See Raul's PR: project-zot/zui#403 Signed-off-by: Andrei Aaron <aaaron@luxoft.com>
Signed-off-by: Raul-Cristian Kele raulkeleblk@gmail.com
What type of PR is this?
feature
Which issue does this PR fix:
Closes #373
What does this PR do / Why do we need it:
Implement api key management page
Implement integration with the api key management backend feature
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this change require updates to the CNI daemonset config files to work?:
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.