feat(playlist): add M3U parser with UTF-8/Cyrillic filename support#996
Open
Dipendra367 wants to merge 1 commit intoprojectM-visualizer:masterfrom
Open
feat(playlist): add M3U parser with UTF-8/Cyrillic filename support#996Dipendra367 wants to merge 1 commit intoprojectM-visualizer:masterfrom
Dipendra367 wants to merge 1 commit intoprojectM-visualizer:masterfrom
Conversation
Adds a new M3UParser class that reads .m3u and .m3u8 playlist files and loads presets into the playlist. Handles UTF-8 encoded filenames including Cyrillic and other non-ASCII characters correctly by: - Opening files in binary mode to preserve UTF-8 bytes - Stripping Windows CR line endings safely - Using direct char comparison for '#' (0x23) instead of ctype functions that would misinterpret high-byte UTF-8 sequences Fixes projectM-visualizer#962
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #962
What this does
Adds a new
M3UParserclass that reads.m3uand.m3u8playlistfiles into the projectM playlist library.
Why it was broken
No M3U parser existed at all — the playlist library could only scan
directories for
.milkfiles.How it works
\rCR line endings safely#EXTM3U/#EXTINFmetadata lines using direct'#'charcomparison (0x23 is always single-byte in UTF-8)
Playlist::AddItem()—Cyrillic, CJK, and any UTF-8 filename works transparently