-
Notifications
You must be signed in to change notification settings - Fork 13
Description
I believe there was a misunderstanding in #31 and there's some issues after #39 that tried to fix it.
As I understand, the ujust command comes from ublue-os-just. Although there's no reference to the 60-custom.just file in this template as cited in #31, it is referenced by the justfile "/usr/share/ublue-os/justfile" the ujust executable ultimately uses, so I think there wasn't something to be fixed...
Then, after the merge of #39, I see two issues:
i. The bluefin just recipes from @projectbluefin/common are been copied to "/usr/share/ublue-os/just" but they are not being used.
The ujust executable uses the "/usr/share/ublue-os/justfile" file, which in turn imports none of the ".just" files copied from common. Maybe a fix could be copying to "/ctx/custom/ujust" instead of directly to "/usr/share/ublue-os/just", so the just files are consolidated into 60-custom.just in the 10-build script... But then I see a second issue:
ii. Maybe the files shouldn't be copied to the final image by default at all? It seems to me that the state before merging #39 is more the ideal of this template. Instead of copying a specific set of files from projectbluefin/common or ublue-os/brew to the OS by default (which isn't fixing anything), just let it available on context stage, and the template users copy what/if they need/desire.