Skip to content

fix(e2e): build libbpf for amd64 multi-arch e2e binary target#12614

Merged
radTuti merged 1 commit intoprojectcalico:masterfrom
radTuti:fix-e2e-amd64-link
Apr 24, 2026
Merged

fix(e2e): build libbpf for amd64 multi-arch e2e binary target#12614
radTuti merged 1 commit intoprojectcalico:masterfrom
radTuti:fix-e2e-amd64-link

Conversation

@radTuti
Copy link
Copy Markdown
Contributor

@radTuti radTuti commented Apr 24, 2026

The multi-arch pattern rule bin/k8s/e2e-linux-%.test (added in #12506) dropped the $(LIBBPF_A) prereq and DOCKER_RUN_CGO wiring. Only amd64 needs them — other arches have CGO off and compile the //go:build !cgo stub. amd64 fails to link on a clean tree with undefined reference to libbpf_strerror_r.

Add an explicit bin/k8s/e2e-linux-amd64.test rule (CGO + libbpf) and have bin/k8s/e2e.test rename it for local use (mv, not ln).

Release note:

None

@radTuti radTuti requested a review from a team as a code owner April 24, 2026 18:47
@marvin-tigera marvin-tigera added this to the Calico v3.33.0 milestone Apr 24, 2026
@marvin-tigera marvin-tigera added release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Apr 24, 2026
@radTuti radTuti added release-note-not-required Change has no user-facing impact docs-not-required Docs not required for this change labels Apr 24, 2026
@marvin-tigera marvin-tigera removed release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Apr 24, 2026
@radTuti radTuti force-pushed the fix-e2e-amd64-link branch from d37069f to 9df46b7 Compare April 24, 2026 18:54
Comment thread e2e/Makefile Outdated
@radTuti radTuti force-pushed the fix-e2e-amd64-link branch 3 times, most recently from 1cea8a5 to e53742b Compare April 24, 2026 22:44
@radTuti radTuti changed the title fix(e2e): route amd64 multi-arch target through canonical e2e.test recipe fix(e2e): build libbpf for amd64 multi-arch e2e binary target Apr 24, 2026
@radTuti radTuti force-pushed the fix-e2e-amd64-link branch from e53742b to 64da3a0 Compare April 24, 2026 22:51
The multi-arch pattern rule bin/k8s/e2e-linux-%.test (added in projectcalico#12506)
dropped the $(LIBBPF_A) prereq and DOCKER_RUN_CGO wiring. Only amd64
needs them -- other arches have CGO off and compile the //go:build !cgo
stub. amd64 fails to link on a clean tree with "undefined reference to
libbpf_strerror_r".

Add an explicit bin/k8s/e2e-linux-amd64.test rule (CGO + libbpf) and
have bin/k8s/e2e.test rename it for local use (mv, not ln).
@radTuti radTuti force-pushed the fix-e2e-amd64-link branch from 64da3a0 to bb7c7c1 Compare April 24, 2026 22:52
@radTuti radTuti enabled auto-merge (squash) April 24, 2026 23:19
@radTuti radTuti merged commit fd13afd into projectcalico:master Apr 24, 2026
3 checks passed
@radTuti radTuti deleted the fix-e2e-amd64-link branch April 25, 2026 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants