-
Notifications
You must be signed in to change notification settings - Fork 17
[#136] Add 'recent activities' to tracking screen #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
elbenfreund
wants to merge
25
commits into
develop
Choose a base branch
from
feature/136
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
54fcc75
Wrap 'make test' with 'xvfb-run'
elbenfreund 975623e
Add inline comments
elbenfreund 334753c
Add dedicated helper for fetching recent activities
elbenfreund 4c5b85e
Add 'recent activities' to start-tracking view
elbenfreund 5c17e7a
Sizing for recent activity widget
elbenfreund d941aab
Adjust existing tests
elbenfreund 8593902
rename 'row_counter' parameter to 'row_index'
elbenfreund c08bd74
Fix typo
elbenfreund bec62d8
Change wording within preferences.
elbenfreund ddafbd1
fix ordering for 'get_recent_activities' helper
elbenfreund fa93742
Account for empty children when figuring out min_height
elbenfreund 5b16ae9
Recent activities box uses last 24h
elbenfreund bd39965
Fix docstring
elbenfreund 9ccdc80
Improve 'config' fixture
elbenfreund 09aaac6
Fix 'app' fixture
elbenfreund 95fc765
Fix test if 'HamsterGTK' instantiation
elbenfreund c0dd639
Rename 'tracking_recent_activities_items' to 'count'
elbenfreund 2177d68
helpers: Refactor 'serialize_activity'
elbenfreund 4b2819b
tracking: Improve categoryless fact serialization
elbenfreund 90dbcc7
Fix typos
elbenfreund fa8057d
tracking: Add issue reference to ToDo comment
elbenfreund 72af08c
helpers: Remove 'none_category' argument on serialize_activity
elbenfreund d685bf2
tests: Fix docker setup
elbenfreund c510594
Fix imports
elbenfreund 1df269a
helpers: Add tests for 'serialize_activity'
elbenfreund File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,9 +14,19 @@ | |
| class TestHamsterGTK(object): | ||
| """Unittests for the main app class.""" | ||
|
|
||
| def test_instantiation(self): | ||
| """Make sure class instatiation works as intended.""" | ||
| app = hamster_gtk.HamsterGTK() | ||
| def test_instantiation(self, config): | ||
| """ | ||
| Make sure class instatiation works as intended. | ||
| We actually test against a monkeypatched class in order to avoid the | ||
| config loading machinery as this would access the user data on fs. | ||
| The relevant skiped methods need to be tested separately. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. skipped |
||
| """ | ||
| def monkeypatched_reload_config(self): | ||
| return config | ||
| HamsterGTK = hamster_gtk.HamsterGTK | ||
| HamsterGTK._reload_config = monkeypatched_reload_config | ||
| app = HamsterGTK() | ||
| assert app | ||
|
|
||
| def test__reload_config(self, app, config, mocker): | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instatiation → instantiation