Skip to content

Add support for proxy env vars #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TheBigLee merged 1 commit into from
Aug 24, 2021
Merged

Add support for proxy env vars #18

TheBigLee merged 1 commit into from
Aug 24, 2021

Conversation

@TheBigLee
Copy link
Member

@TheBigLee TheBigLee commented Aug 23, 2021

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation.
  • Update the ./CHANGELOG.md.
  • Link this PR to related issues.

@TheBigLee TheBigLee force-pushed the feature/proxy_envs branch 3 times, most recently from 03991e7 to 6a420b6 Compare August 23, 2021 15:22
@bastjan bastjan added the enhancement New feature or request label Aug 23, 2021
bastjan
bastjan approved these changes Aug 23, 2021
View reviewed changes
Copy link
Member

@bastjan bastjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I added the label enhancement for the Generated changelog.

@TheBigLee TheBigLee merged commit 1118ee0 into master Aug 24, 2021
@TheBigLee TheBigLee deleted the feature/proxy_envs branch August 24, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bastjan bastjan bastjan approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TheBigLee @bastjan