promslog: use UTC timestamps for go-kit log style#696
Merged
SuperQ merged 1 commit intoprometheus:mainfrom Sep 20, 2024
Merged
Conversation
promlog initialized its go-kit logger to use UTC timestamps, so for true backwards compatibility, the go-kit log style in promslog should retain that configuration. Signed-off-by: Daniel Swarbrick <daniel.swarbrick@gmail.com>
tjhop
approved these changes
Sep 20, 2024
SuperQ
approved these changes
Sep 20, 2024
Member
SuperQ
left a comment
SuperQ
left a comment
There was a problem hiding this comment.
I think we should also do this for normal slog logging as well. We have a UTC policy for logging because we have a UTC policy for the metrics store in the TSDB.
This make sure we always get aligned time when comparing Prometheus logs and metrics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
promlog initialized its go-kit logger to use UTC timestamps, so for true backwards compatibility, the go-kit log style in promslog should retain that configuration.