Allow passing of TLS certificates inline#158
Merged
roidelapluie merged 5 commits intoprometheus:masterfrom Jul 14, 2023
Merged
Conversation
fayzal-g
force-pushed
the
pass-tls-config-inline
branch
2 times, most recently
from
33077e9 to
9864078
Compare
Contributor
Author
|
cc @SuperQ |
SuperQ
requested changes
Jun 14, 2023
Member
SuperQ
left a comment
SuperQ
left a comment
There was a problem hiding this comment.
Please update /docs/web-configuration.md
Signed-off-by: fayzal-g <fayzal.ghantiwala@grafana.com>
Signed-off-by: fayzal-g <fayzal.ghantiwala@grafana.com>
Signed-off-by: fayzal-g <fayzal.ghantiwala@grafana.com>
Signed-off-by: fayzal-g <fayzal.ghantiwala@grafana.com>
fayzal-g
force-pushed
the
pass-tls-config-inline
branch
from
47a4047 to
448bd14
Compare
Signed-off-by: fayzal-g <fayzal.ghantiwala@grafana.com>
Contributor
Author
|
Thanks. Now updated |
Contributor
Author
|
@SuperQ @roidelapluie Would it be possible to get this merged? |
Contributor
Author
|
@roidelapluie Sorry for the double ping, but would love to use this upstream. Any chance you could take a look? |
fayzal-g
changed the title
Member
|
Thanks! |
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was suggested in #157
This PR allows the
TLSCert,TLSKeyandClientCAsto be passed inline as a string as part of theTLSConfig. The contents of these is expected to be exactly the same as a file, a PEM-encoded sequence of bytes.