-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Description
Description
Improve test coverage for the archive scanner family: tar_scanner, zip_scanner, and sevenzip_scanner. These scanners handle nested model files inside archives and need thorough edge case testing.
Suggested test cases
- Archives containing multiple model files of different formats
- Deeply nested archives (archive within archive)
- Archives with symbolic links (security-relevant)
- Archives with path traversal attempts (e.g.,
../../etc/passwd) - Empty archives
- Corrupted/truncated archives
- Archives with very long filenames
References
modelaudit/scanners/tar_scanner.pymodelaudit/scanners/zip_scanner.pymodelaudit/scanners/sevenzip_scanner.pytests/scanners/test_tar_scanner.py— existing tests to extendtests/scanners/test_zip_scanner.py— existing tests to extenddocs/agents/testing.md— test patterns guide
Getting started
uv sync --extra all-ci
uv run pytest tests/scanners/test_tar_scanner.py tests/scanners/test_zip_scanner.py -vAcceptance criteria
- At least 3 new test cases per scanner
- Tests cover at least one security-relevant edge case
- All tests pass:
uv run pytest -n auto -m "not slow"
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed