Retain existing array in RepeatedField.Clear#10508
Merged
fowles merged 1 commit intoprotocolbuffers:mainfrom Sep 7, 2022
Merged
Retain existing array in RepeatedField.Clear#10508fowles merged 1 commit intoprotocolbuffers:mainfrom
fowles merged 1 commit intoprotocolbuffers:mainfrom
Conversation
Fixes protocolbuffers#7828. (Also tweaks the comment for Capacity.)
Contributor
Author
|
@fowles: Please could you approve and merge (assuming this does indeed seem reasonable to you)? |
fowles
approved these changes
Sep 7, 2022
Contributor
Author
|
@CodeBlanch: I would expect it to be in 3.22.0; I don't have a timeframe for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7828.
(Also tweaks the comment for Capacity.)