[C#] Replace regex that validates descriptor names

[JamesNK]

This PR replaces the descriptor name validation regex with a validation method. This change allows the System.Text.RegularExpressions engine to be trimmed away in published apps that do standard protobuf serialization.

There are some other usages of Regex in Google.Protobuf, but they in JsonParser. They are only included in a published app if JsonParser is used.

Another benefit is a slightly faster app startup time. The removed regex was compiled, which has a high-ish fixed cost.

cc @jskeet @jtattermusch

[jskeet]

Definitely happy with the overall aim - a few nits.

[JamesNK]

All feedback applied.

[JamesNK]

Is this waiting on more reviews? I just want to make sure it doesn't get left behind.

For context, this change saves 1 MB from .NET Native gRPC client and server apps. I'd love to show off the smallest gRPC apps possible in demos 😄

[jskeet]

Thanks for the prod - I'll chase it up.

[jskeet]

@deannagarcia: I think your approval (or at least, someone actually on the Protobuf team) is required before this can proceed.

[JamesNK]

This missed 3.23.0.

Could it be merged now to make it into the next protobuf release?

[jskeet]

@JamesNK: Aargh, sorry that this fell through the cracks.
@deannagarcia: Please could you merge?

[deannagarcia]

Sorry this fell through, working to get it in now.

[jskeet]

@JamesNK: This went out in 3.23.1 :)

[JamesNK]

Nice. Thanks!

[robertodalmonte]

Hi there,
This morning I updated my WPF project from:

to

This is the only change I made.
I published my project using my usual settings:


Release
Any CPU
D:\Github\OneClick\OneClick.Dental\bin\publish
FileSystem
<_TargetId>Folder</_TargetId>
net7.0-windows
win-x64
false
true
true


If I try to launch my WPF client it stops as soon as trying to connect to my gRPC server.
It does not happen if I do the same from Visual Studio in debug or if I launch the exe from the release folder after building.
I rolled back to
and I can publish my WPF project successfully and I'm able to connect as usual to my gRPC Server app.
Is it possible that the last changes might have affected publishing?
Should I look somewhere else?
Best regards
Roberto

[robertodalmonte]

from 3.23 to 3.23.1

[jskeet]

@robertodalmonte: Please file a new issue in https://github.com/grpc/grpc-dotnet with more details - it's not appropriate to use a closed PR to report an issue, even if the issue was caused by the change.

I'd also strongly recommend that in the new issue, you give more detail than "it stops". I expect there's an exception being thrown somewhere - please look for that and give full details of it in the issue.

[robertodalmonte]

Thanks for your suggestion, I will follow it.
I'm sorry for the inappropriate use, it wasn't meant to be.