Conversation
…-for-cis-compliance
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
|
✅ All necessary |
…liance' of https://github.com/prowler-cloud/prowler into PROWLER-1318-feature-implement-pdf-reports-for-cis-compliance
🔒 Container Security ScanImage: ✅ No Vulnerabilities DetectedThe container image passed all security checks. No known CVEs were found.📋 Resources:
|
🔒 Container Security ScanImage: 📊 Vulnerability Summary
4 package(s) affected
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #10650 +/- ##
===========================================
+ Coverage 7.47% 93.74% +86.27%
===========================================
Files 847 229 -618
Lines 24189 32663 +8474
===========================================
+ Hits 1807 30619 +28812
+ Misses 22382 2044 -20338
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Alan-TheGentleman
left a comment
There was a problem hiding this comment.
Two things to tighten up:
-
The new /cis/{name}/ endpoint accepts every CIS variant, but the report job only generates the latest one.
cis()validatesnameagainstget_compliance_frameworks(scan.provider.provider), socis_1.4_awspasses validation even if onlycis_5.0_awswas produced. That means users get a file-not-found 404 for a variant the endpoint just accepted. Either restrict the endpoint contract to the selected variant, or fail earlier with a clearer 'only latest CIS version is generated' response. -
The changelog entry is out of order. The PR adds
1.23.0above1.24.0, which will make the release history confusing. Put the new entry in the right chronological position before merging.
The dynamic variant selection is a good direction, and the path-safety validation on name is solid. Once the endpoint contract matches the generated artifacts, this will be much easier to reason about.
Description
This PR includes the needed changes to add the Prowler PDF compliance reports for the CIS compliance framework.

Steps to review
Please add a detailed description of how to review this PR.
Checklist
Community Checklist
SDK/CLI
UI
API
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.