Skip to content

Conversation

@aitorct
Copy link

@aitorct aitorct commented Oct 4, 2019

Android's isAvailable method now checks if any installed browser supports Custom Tabs.

This solves issue #91.

Copy link
Member

@jdnichollsc jdnichollsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if this solution works for AndroidX 🤔

@wong2
Copy link

wong2 commented Apr 8, 2020

hi, any updates?

@jdnichollsc
Copy link
Member

jdnichollsc commented Apr 8, 2020

Let me know if it works for AndroidX 🙂

@ssuchanowski
Copy link
Contributor

any plan for merging this?

@jdnichollsc
Copy link
Member

@ssuchanowski do you know if it works for AndroidX too?

@ssuchanowski
Copy link
Contributor

Hadn't tested it but it seems like this service name is mentioned here https://developer.android.com/reference/androidx/browser/customtabs/CustomTabsService which is an android x documentation.

@jdnichollsc
Copy link
Member

jdnichollsc commented Jun 19, 2020

Ok, let me check this weekend, thanks for confirm!

@ssuchanowski
Copy link
Contributor

hey @jdnichollsc did you have time to take a look?

There is also another PR (#160) with a simple fix.

@jdnichollsc
Copy link
Member

jdnichollsc commented Jun 24, 2020

@ssuchanowski sorry mate, I was so busy, let me check at night :)
Do you know if we need to set the package? Example: https://stackoverflow.com/a/33041870/1532821

@ssuchanowski
Copy link
Contributor

No idea

@aitorct
Copy link
Author

aitorct commented Jun 24, 2020

Just double-checked, it's working properly! Fixed the merge conflicts as well.

@aitorct aitorct requested a review from jdnichollsc June 24, 2020 18:44
@jdnichollsc jdnichollsc merged commit 2dea12a into proyecto26:master Jun 25, 2020
phuongwd pushed a commit to phuongwd/react-native-inappbrowser that referenced this pull request Jul 31, 2020
Android isAvailable method checks Custom Tab support
@jdnichollsc jdnichollsc mentioned this pull request Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants