Skip to content

Conversation

@ShaneMckenna23
Copy link
Contributor

PR Checklist

What is the current behavior?

Unable to define the size of formSheet modals on iPad

What is the new behavior?

Added new prop to allow for custom sized formSheet modals on iPad.

Implements #330.

Migration steps:

  • No migration steos needed, new prop is optional.

Screenshots

width-500-height-800.mov
width-500-height-600.mov

@jdnichollsc
Copy link
Member

Hey mate, this is amazing!

One question, what happen with the modal if the device is rotated with the browser open? 🤔

Thanks for your contribution! <3

@jdnichollsc jdnichollsc merged commit 0b942ba into proyecto26:develop May 20, 2022
@jdnichollsc
Copy link
Member

Thanks for your amazing contribution dude! <3

@jdnichollsc jdnichollsc mentioned this pull request Jul 29, 2022
@jdnichollsc jdnichollsc self-requested a review July 29, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants