Fix mem_max_rss measurement on macOS #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On BSD/darwin, ru_maxrss is defined in "bytes", unlike Linux where it is "kilobytes". Therefore, this code was wrongly multiplying the result by 1024. Rather than just fixing it here, it seems better to reuse the already correct `get_max_rss` function (used for calculating `command_max_rss`) elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On BSD/darwin, ru_maxrss is defined in "bytes", unlike Linux where it is "kilobytes". Therefore, this code was wrongly multiplying the result by 1024. Rather than just fixing it here, it seems better to reuse the already correct
get_max_rssfunction (used for calculatingcommand_max_rss) elsewhere.