Refactor operations to fully work on AArch64. #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create IntelPstateOperation class for Intel P-State operations. Enable CPUGovernor on AArch64 platforms.
Contributor
Author
Member
|
I will take a look by this weekend :) |
vstinner
reviewed
May 23, 2024
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
Can you try to avoid moving code? It makes the diff harder to review.
Like leaving TurboBoostIntelPstate after TurboBoostMSR.
corona10
reviewed
May 23, 2024
corona10
reviewed
May 23, 2024
corona10
reviewed
May 23, 2024
vstinner
reviewed
May 23, 2024
Contributor
Author
Done, I tried moving less code possible. |
Co-authored-by: Victor Stinner <[email protected]>
corona10
approved these changes
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create IntelPstateOperation class for Intel P-State operations.
Enable CPUGovernor on AArch64 platforms.
Replace all Class names with super() in the init method.