Skip to content

Updated nids for SysclibForKernel #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
krazynez wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Updated nids for SysclibForKernel #334

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d983f41
updated nids
krazynez Nov 26, 2025
f74a1fd
updated automake file
krazynez Nov 26, 2025
f3a3def
appened to bottom instead
krazynez Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/kernel/SysclibForKernel.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,13 @@
IMPORT_FUNC "SysclibForKernel",0x8AF6B8F8,SysclibForKernel_8AF6B8F8
#endif
#ifdef F_SysclibForKernel_0015
IMPORT_FUNC "SysclibForKernel",0xDF17F4A2,SysclibForKernel_DF17F4A2
IMPORT_FUNC "SysclibForKernel",0xDF17F4A2,__udivmoddi4
#endif
#ifdef F_SysclibForKernel_0016
IMPORT_FUNC "SysclibForKernel",0x7DEE14DE,SysclibForKernel_7DEE14DE
IMPORT_FUNC "SysclibForKernel",0x7DEE14DE,__udivdi3
#endif
#ifdef F_SysclibForKernel_0017
IMPORT_FUNC "SysclibForKernel",0x5E8E5F42,SysclibForKernel_5E8E5F42
IMPORT_FUNC "SysclibForKernel",0x5E8E5F42,__umoddi3
#endif
#ifdef F_SysclibForKernel_0018
IMPORT_FUNC "SysclibForKernel",0xC0AB8932,strcmp
Expand Down Expand Up @@ -123,11 +123,14 @@
IMPORT_FUNC "SysclibForKernel",0x7661E728,sprintf
#endif
#ifdef F_SysclibForKernel_0040
IMPORT_FUNC "SysclibForKernel",0x909C228B,setjmp
IMPORT_FUNC "SysclibForKernel",0xC2145E80,snprintf
Copy link
Contributor

@rofl0r rofl0r Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this switched ?

Copy link
Author

@krazynez krazynez Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can move it down, was putting it near sprintf, also need to update the Makefile.am to add the missing F_SysclibForKernel_ function for snprintf or the offset. Just noticed that.

Copy link
Contributor

@rofl0r rofl0r Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usually keeping diffs minimal is the best course of action (i.e. leave the existing longjmp/setjmp blocks as they were)

Copy link
Author

@krazynez krazynez Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay no prob I will append it to the bottom 👍

#endif
#ifdef F_SysclibForKernel_0041
IMPORT_FUNC "SysclibForKernel",0x18FE80DB,longjmp
IMPORT_FUNC "SysclibForKernel",0x909C228B,setjmp
#endif
#ifdef F_SysclibForKernel_0042
IMPORT_FUNC "SysclibForKernel",0x18FE80DB,longjmp
#endif
#ifdef F_SysclibForKernel_0043
IMPORT_FUNC "SysclibForKernel",0x1493EBD9,wmemset
#endif