chore: adjust how contact items are constructed#145
Conversation
Use a dedicated item for contact items.
Due to updates to `github-link` we have to update the test reference image.
|
Minor nitpick: diff --git a/lib.typ b/lib.typ
index 8a19150..a09ef89 100644
--- a/lib.typ
+++ b/lib.typ
@@ -338,6 +338,7 @@
// - link-prefix (string): The prefix to use for the link (e.g. "mailto:")
let contact-item(item, link-prefix: "") = {
box[
+ #set align(bottom)
#if ("icon" in item) {
[#item.icon]
}I'd add that extra align to ensure they line up at the bottom like previously. |
Thanks for the feedback! Do you prefer the bottom alignment over having the icon centered (vertically) with respect to the text? |
|
I prefer the bottom one simply because it forms a relatively consistent visual line (with exception of qpjy). The center alignment seems a bit chaotic to me, I'm not sure if it works with every icon correctly. |
That's a fair point, thanks for the feedback! |
Align the icons and text to "bottom" per feedback for the contact headers items.
Changes
github-linkhelper@paulrauecker Would you mind looking at this as it's related to some of the issues I was seeing in #144.
Note that this doesn't include changes to how the contact items in the coverletter are constructed. That can be a follow up PR if this one works well.