Skip to content

Tests - Internal #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AdrianRomanski wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Tests - Internal #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/nx-verdaccio/src/internal/terminal.unit-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,10 @@ describe('objectToCliArgs', () => {
expect(objectToCliArgs(params)).toStrictEqual([]);
});

it('should early return an empty array if params are not present', () => {
Copy link
Contributor

@BioPhoton BioPhoton Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
it('should early return an empty array if params are not present', () => {
it('should return an empty array if params are not present', () => {

If we can't test that the return is early i would leave it out for brevity.

expect(objectToCliArgs(undefined)).toStrictEqual([]);
});

it('should throw error for unsupported type', () => {
const params = { unsupported: Symbol('symbol') };
expect(() => objectToCliArgs(params)).toThrow('Unsupported type');
Expand Down