DAPP-1972 price tracker activity + blocks fixes

[rohitmalhotra1420]

Pull Request Template

Ticket Number

• 1972

Description

• Problem/Feature:

Type of Change

• Added a new btc tracker activity
• Did some design system fixes as well

• Bug fix
• New feature
• Code refactor
• Documentation update
• Other (please describe):

Checklist

• Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
  • Quick PR label added
• Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
  • DO NOT Merge PR label added

Frontend Guidelines

• Followed frontend guidelines as per the Guidelines Notion Doc

Build & Testing

• No errors in the build terminal
• Engineer has tested the changes on their local environment
• Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

• Before: Explain the previous behavior

• After: What's changed now

Additional Context

Review & Approvals

• Self-review completed
• Code review by at least one other engineer
• Documentation updates if applicable

Notes

[github-actions]

In the file src/blocks/icons/components/Asterisk.tsx:

1. The SVG paths are missing the tags.
2. The attribute "width" should be set to a specific value like "32px" instead of "inherit".
3. The attributes within the tags should be camelCase like "strokeWidth" instead of "stroke-width".

In the file src/blocks/icons/components/Lock.tsx:

1. The SVG paths are missing the and tags.
2. The attribute "width" should be set to a specific value like "32px" instead of "inherit".
3. The attributes within the and tags should be camelCase like "strokeWidth" instead of "stroke-width" and "rx" should have a value like "3px" instead of just "3".

In the file src/blocks/icons/components/Logout.tsx:

1. The SVG paths are missing the tags.
2. The attribute "width" should be set to a specific value like "32px" instead of "inherit".
3. The attributes within the tags should be camelCase like "strokeWidth" instead of "stroke-width".

In the file src/blocks/text/Text.constants.ts:

1. There are missing closing braces in the object definitions like 'bes-regular-italic', 'ol-bold', etc.

In the file src/modules/rewards/components/RewardsActivityIcon.tsx:

1. The conditionals inside the component are missing the return keyword before the component elements like <Twitter.
2. Some images are missing the tag for rendering images.
3. The imports for components like Discord, Twitter, etc. should not be wrapped in curly braces as they are default exports from their respective files.
4. There are missing default exports at the end of the file.

Other files seem to be mostly type definitions and imports which are difficult to assess just by glancing through the code.

In general, please ensure that all components are properly defined, all imports are correctly written, and all code follows consistent formatting conventions.

All looks good.

[github-actions]

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-11-20 07:33 UTC