Rewards S1 closing

[corlard3y]

Pull Request Template

Ticket Number

• Ticket Number

Description

• Problem/Feature:

Type of Change

• Bug fix
• New feature
• Code refactor
• Documentation update
• Other (please describe):

Checklist

• Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
  • Quick PR label added
• Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
  • DO NOT Merge PR label added

Frontend Guidelines

• Followed frontend guidelines as per the Guidelines Notion Doc

Build & Testing

• No errors in the build terminal
• Engineer has tested the changes on their local environment
• Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

• Before: Explain the previous behavior

• After: What's changed now

Additional Context

Review & Approvals

• Self-review completed
• Code review by at least one other engineer
• Documentation updates if applicable

Notes

[github-actions]

In DashboardSectionHeader.tsx:

1. The Button component is missing a closing tag with 'children' prop. It should be <Button ...>Get Started</Button>.
2. The background CSS property in the styled-component should end with a semicolon.
3. There are some ellipses at the end of the file which may not be necessary.
4. Some parts of the code are missing due to truncation.

In Header.tsx:

1. There is an unfinished statement after the closing curly brace of the RewardsHeaderLink component.
2. In the Text component, there is a missing closing tag before variant="h5-bold" line.
3. Lozenge component should have proper closing tag and props like variant and display.
4. The Header component is missing some parts of the code due to truncation.
5. There is an unfinished comment line // Change text based on change of location.

Please provide more context or the full code for a thorough review.

[github-actions]

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2025-02-28 15:15 UTC