Skip to content

Update yield farming#2028

Merged
riyanshu-patro merged 1 commit intomainfrom
yield-farming-changes
Mar 12, 2025
Merged

Update yield farming#2028
riyanshu-patro merged 1 commit intomainfrom
yield-farming-changes

Conversation

@riyanshu-patro
Copy link
Copy Markdown
Collaborator

Pull Request Template

Ticket Number

Description

  • Problem/Feature:

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior

  • After: What's changed now

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

@github-actions
Copy link
Copy Markdown

In file YieldPushFeeV3.tsx:

  • Missing closing tag for TransactionModal component.
  • Typo in PUSHPoolstats variable should be lowercase.
  • Typo in SpanV2 component, ">" should be replaced with ">".
  • Typo in SkeletonLine component, missing closing tag for the second component.

In file YieldUniswapV3.tsx:

  • Typo in lpPoolStats variable should be lowercase.
  • Typo in Button component, missing closing tag for the disabled attribute.

In file NewYieldFarming.tsx:

  • Missing closing tag for YieldStatsSection component.
  • Missing closing tag for the set function of YieldStatsSection component.
  • Typo in setActiveTab parameter of YieldAnnouncementSection, should be setActiveTab={}.
  • Missing closing tag for the YieldStatsSection component.
  • Missing closing angle bracket in the Button component.
  • Typo in Button component, "Stake $UNI-V2 LP Tokens" should be wrapped in an element like a span for text display.
  • Typo in Skeleton component, multiple closing tags for SkeletonLine component.
  • Typo in ItemHV2 component, missing closing tag for the root element.

In file YieldStatsSection.tsx:

  • Typo in StatsContainer component, missing closing tag.
  • Typo in BgCircleEffect component, missing closing tag.
  • Typo in TextBox component, justifyContent="end" should be replaced with justifyContent="flex-end".
  • Typo in commented out StatsContainer component.
  • Typo in SkeletonLoader component, missing closing tag for the SkeletonLine component.

All looks good.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 12, 2025

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2025-03-12 20:22 UTC

@riyanshu-patro riyanshu-patro self-assigned this Mar 12, 2025
@riyanshu-patro riyanshu-patro merged commit b7f2ad7 into main Mar 12, 2025
2 of 3 checks passed
@riyanshu-patro riyanshu-patro deleted the yield-farming-changes branch March 12, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants