Skip to content

Change the header tag from ENDED to SEASON 2#2036

Merged
riyanshu-patro merged 2 commits intomainfrom
tag-text-change
Apr 28, 2025
Merged

Change the header tag from ENDED to SEASON 2#2036
riyanshu-patro merged 2 commits intomainfrom
tag-text-change

Conversation

@riyanshu-patro
Copy link
Copy Markdown
Collaborator

Pull Request Template

Ticket Number

Description

  • Problem/Feature:

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior

  • After: What's changed now

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2025

  • There is a missing import for the Container component.
  • The Styled component in the Header function is not imported and should be imported from styled-components.
  • The Container styled component should be wrapped around the JSX returned in the Header function.
  • Unused variables like isMobile and isSnapPage can be removed to clean up the code.
  • In the updateHeaderTag function, the condition if (EXTRA_HEADER_TAGS[location.pathname]) should be outside the Object.entries loop to set the headerTag.
  • The HeaderTag styled component is referring to the Span component inside it. It should be corrected to use styled(Span) instead of just Span.

All looks good.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2025

PR Preview Action v1.4.7
🚀 Deployed preview to https://push-protocol.github.io/push-dapp/pr-preview/pr-2036/
on branch gh-pages at 2025-04-03 21:26 UTC

abhishek-01k
abhishek-01k previously approved these changes Apr 3, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2025

All looks good.

@abhishek-01k abhishek-01k self-requested a review April 28, 2025 10:47
@riyanshu-patro riyanshu-patro merged commit f8b794c into main Apr 28, 2025
2 checks passed
@riyanshu-patro riyanshu-patro deleted the tag-text-change branch April 28, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants