38 add data loaders for common first order datasets#77
Merged
Conversation
Comment on lines
+138
to
+139
| covered = preds[np.arange(preds.shape[0]), targets] | ||
| ceff = np.mean(preds[covered]) |
There was a problem hiding this comment.
The indexing in the 2D case appears incorrect. 'covered' is derived from selecting values via np.arange and targets, so using it directly to index preds may not produce the intended boolean mask of covered instances. Consider revising the logic to compute the set size or to use an appropriate boolean mask representing covered predictions.
Suggested change
| covered = preds[np.arange(preds.shape[0]), targets] | |
| ceff = np.mean(preds[covered]) | |
| covered = preds[np.arange(preds.shape[0]), targets] == targets | |
| ceff = np.mean(np.sum(preds[covered], axis=1)) |
pwhofman
deleted the
38-add-data-loaders-for-common-first-order-datasets
branch
elias0224
pushed a commit
to elias0224/probly
that referenced
this pull request
Oct 30, 2025
* Add covered efficiency metric * Add ImageNet-ReaL and multiple DCICDatasets
davyddzhalaiansamani
pushed a commit
to D4V1ND/probly
that referenced
this pull request
Dec 10, 2025
* Add covered efficiency metric * Add ImageNet-ReaL and multiple DCICDatasets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.