Open
Conversation
Member
|
Just to give an update here: I am thinking of moving all the gtk bits to zathura proper. At this point, the split is mostly historical. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to automate testing UI interactions to avoid regressions when changing core components like the document widget. The following adds shortcuts to record and playback a macro, which contains keystrokes, assertions and breakpoints. There'll be more documentation and an example of using this in the Zathura PR. This could also form the basis for a macro system in Zathura similar to Vim macros.
Something I found while testing was in
simulate_key_pressfrom the feedkeys shortcut, gtk wouldn't always finish "processing" an event (e.g. more events remaining) before starting the next one leading to improper behaviour. Usinginstead of
gtk_main_iteration_do(FALSE)seems to help this, since it'll wait until there are not more events before moving on to the next key event.