Fix Host cleanup to avoid kill(0) and track target PID correctly#8
Open
ConnorNelson wants to merge 2 commits intomasterfrom
Open
Fix Host cleanup to avoid kill(0) and track target PID correctly#8ConnorNelson wants to merge 2 commits intomasterfrom
ConnorNelson wants to merge 2 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Network hosts can run without NS.PID, leaving host_target_pids[...] at 0. The prior unconditional os.kill(host_target_pids[..].value, 9) can become kill(0, SIGKILL), which kills the current process group and can tear down the whole container under kata.
This change keeps cleanup behavior for PID-namespace hosts but prevents accidental process-group kills.