2D

[aabills]

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

• No style issues: nox -s pre-commit
• All tests pass: nox -s tests
• The documentation builds: nox -s doctests
• Code is commented for hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

❌ Patch coverage is 93.85965% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.90%. Comparing base (6d60ee7) to head (d9e0aa6).
⚠️ Report is 159 commits behind head on develop.

Files with missing lines	Patch %	Lines
src/pybamm/solvers/processed_variable.py	69.09%	17 Missing ⚠️
...ls/full_battery_models/lithium_ion/basic_dfn_2d.py	94.39%	6 Missing ⚠️
src/pybamm/discretisations/discretisation.py	98.30%	1 Missing ⚠️
src/pybamm/expression_tree/unary_operators.py	97.56%	1 Missing ⚠️
src/pybamm/expression_tree/vector_field.py	96.00%	1 Missing ⚠️
src/pybamm/meshes/meshes.py	98.03%	1 Missing ⚠️
src/pybamm/plotting/quick_plot.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #5106      +/-   ##
===========================================
- Coverage    99.06%   98.90%   -0.17%     
===========================================
  Files          312      316       +4     
  Lines        24671    26194    +1523     
===========================================
+ Hits         24440    25906    +1466     
- Misses         231      288      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[rtimms]

thanks @aabills , overall looks great! just a few comments, mostly minor