Skip to content

Boundary mesh size#5108

Merged
aabills merged 12 commits intopybamm-team:developfrom
aabills:boundary-mesh-size
Jul 11, 2025
Merged

Boundary mesh size#5108
aabills merged 12 commits intopybamm-team:developfrom
aabills:boundary-mesh-size

Conversation

@aabills
Copy link
Contributor

@aabills aabills commented Jul 9, 2025

Description

follow up to #5107 providing the distance from the center of the control volume to the edge at the boundary

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@aabills aabills requested a review from a team as a code owner July 9, 2025 20:16
@aabills aabills requested a review from MarcBerliner July 9, 2025 20:21
@codecov
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.09%. Comparing base (6b05386) to head (d8a5324).
⚠️ Report is 147 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5108      +/-   ##
===========================================
- Coverage    99.10%   99.09%   -0.01%     
===========================================
  Files          307      307              
  Lines        23686    23708      +22     
===========================================
+ Hits         23473    23494      +21     
- Misses         213      214       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aabills aabills merged commit abaf83a into pybamm-team:develop Jul 11, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants