1D+ sensitivities error with IDAKLU output_variables#5118
Merged
MarcBerliner merged 6 commits intopybamm-team:developfrom Sep 17, 2025
Merged
1D+ sensitivities error with IDAKLU output_variables#5118MarcBerliner merged 6 commits intopybamm-team:developfrom
MarcBerliner merged 6 commits intopybamm-team:developfrom
Conversation
Contributor
Author
|
Requires: pybamm-team/pybammsolvers#52 |
Member
|
@pipliggins |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5118 +/- ##
========================================
Coverage 98.80% 98.80%
========================================
Files 320 320
Lines 27034 27034
========================================
Hits 26711 26711
Misses 323 323 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
@MarcBerliner Yes! I'll mark it ready. |
pipliggins
added a commit
to pipliggins/PyBaMM
that referenced
this pull request
Oct 13, 2025
* Adds a test checking for sensitivitiy equality between output_variables=True/False * Test with 0D, 1D and 2D variables which should all have non-zero sensitivities * Update changelog --------- Co-authored-by: Marc Berliner <34451391+MarcBerliner@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using
output_variables, sensitivity calculations were incorrect for 1D+ variables, and all variables which followed them in theoutput_variableslist. This is a bug in the C++ code stored in pybammsolvers so a seperate PR will be made there, this one just adds tests to pybamm that catch the bug and should pass once the solvers package is fixed and updated.Fixes #5058
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)