Pass inputs through set_initial_soc#5122
Merged
MarcBerliner merged 3 commits intopybamm-team:developfrom Jul 21, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5122 +/- ##
========================================
Coverage 99.12% 99.12%
========================================
Files 309 309
Lines 24134 24136 +2
========================================
+ Hits 23922 23924 +2
Misses 212 212 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MarcBerliner
requested changes
Jul 18, 2025
Member
MarcBerliner
left a comment
There was a problem hiding this comment.
Thanks @NicolaCourtier, looks great! Can you please add a test?
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pass the
inputsdictionary further through theset_initial_socfunction.Fixes #5121
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)
Important checks:
Please confirm the following before marking the PR as ready for review:
nox -s pre-commitnox -s testsnox -s doctests