Skip to content

Pass inputs through set_initial_soc#5122

Merged
MarcBerliner merged 3 commits intopybamm-team:developfrom
NicolaCourtier:5121-initial-inputs
Jul 21, 2025
Merged

Pass inputs through set_initial_soc#5122
MarcBerliner merged 3 commits intopybamm-team:developfrom
NicolaCourtier:5121-initial-inputs

Conversation

@NicolaCourtier
Copy link
Contributor

Description

Pass the inputs dictionary further through the set_initial_soc function.

Fixes #5121

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@NicolaCourtier NicolaCourtier marked this pull request as ready for review July 18, 2025 09:44
@NicolaCourtier NicolaCourtier requested a review from a team as a code owner July 18, 2025 09:44
@codecov
Copy link

codecov bot commented Jul 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.12%. Comparing base (1a39a99) to head (9de9660).
⚠️ Report is 153 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5122   +/-   ##
========================================
  Coverage    99.12%   99.12%           
========================================
  Files          309      309           
  Lines        24134    24136    +2     
========================================
+ Hits         23922    23924    +2     
  Misses         212      212           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@MarcBerliner MarcBerliner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NicolaCourtier, looks great! Can you please add a test?

Copy link
Member

@MarcBerliner MarcBerliner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarcBerliner MarcBerliner merged commit 1de58ed into pybamm-team:develop Jul 21, 2025
22 checks passed
@NicolaCourtier NicolaCourtier deleted the 5121-initial-inputs branch July 21, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable passing of inputs throughout set_initial_soc

2 participants