Skip to content

composite esoh#5160

Merged
aabills merged 7 commits intopybamm-team:developfrom
aabills:composite-hysteresis-esoh
Aug 14, 2025
Merged

composite esoh#5160
aabills merged 7 commits intopybamm-team:developfrom
aabills:composite-hysteresis-esoh

Conversation

@aabills
Copy link
Contributor

@aabills aabills commented Aug 12, 2025

Description

adds composite electrode soh model

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

❌ Patch coverage is 97.54902% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.89%. Comparing base (8881758) to head (667579f).
⚠️ Report is 158 commits behind head on develop.

Files with missing lines Patch % Lines
...tery_models/lithium_ion/electrode_soh_composite.py 98.14% 3 Missing ⚠️
...s/full_battery_models/lithium_ion/initial_state.py 96.15% 1 Missing ⚠️
...amm/models/full_battery_models/lithium_ion/util.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5160      +/-   ##
===========================================
- Coverage    98.90%   98.89%   -0.02%     
===========================================
  Files          318      320       +2     
  Lines        26231    26430     +199     
===========================================
+ Hits         25943    26137     +194     
- Misses         288      293       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aabills aabills marked this pull request as ready for review August 12, 2025 22:31
@aabills aabills requested a review from a team as a code owner August 12, 2025 22:31
@aabills aabills merged commit 08008d1 into pybamm-team:develop Aug 14, 2025
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants