fix calculation of bulk ocp in hysteresis models#5169
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5169 +/- ##
===========================================
- Coverage 98.88% 98.87% -0.01%
===========================================
Files 320 320
Lines 26875 26872 -3
===========================================
- Hits 26574 26571 -3
Misses 301 301 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aabills
requested changes
Aug 20, 2025
Contributor
aabills
left a comment
There was a problem hiding this comment.
looks like a few forgotten print statements, otherwise looks good.
src/pybamm/models/submodels/interface/open_circuit_potential/base_ocp.py
Outdated
Show resolved
Hide resolved
src/pybamm/models/submodels/interface/open_circuit_potential/one_state_hysteresis_ocp.py
Outdated
Show resolved
Hide resolved
aabills
previously approved these changes
Aug 20, 2025
aabills
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # (issue)
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)
Important checks:
Please confirm the following before marking the PR as ready for review:
nox -s pre-commitnox -s testsnox -s doctests