Skip to content

fix calculation of bulk ocp in hysteresis models#5169

Merged
rtimms merged 5 commits intodevelopfrom
fix-bulk-ocp-hysteresis
Aug 28, 2025
Merged

fix calculation of bulk ocp in hysteresis models#5169
rtimms merged 5 commits intodevelopfrom
fix-bulk-ocp-hysteresis

Conversation

@rtimms
Copy link
Contributor

@rtimms rtimms commented Aug 19, 2025

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.87%. Comparing base (6618fe1) to head (fa6a9ba).
⚠️ Report is 97 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5169      +/-   ##
===========================================
- Coverage    98.88%   98.87%   -0.01%     
===========================================
  Files          320      320              
  Lines        26875    26872       -3     
===========================================
- Hits         26574    26571       -3     
  Misses         301      301              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rtimms rtimms marked this pull request as ready for review August 20, 2025 08:55
@rtimms rtimms requested a review from a team as a code owner August 20, 2025 08:55
Copy link
Contributor

@aabills aabills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a few forgotten print statements, otherwise looks good.

aabills
aabills previously approved these changes Aug 20, 2025
@rtimms rtimms enabled auto-merge (squash) August 25, 2025 16:37
@rtimms rtimms requested a review from aabills August 28, 2025 13:02
@rtimms rtimms merged commit acff2a2 into develop Aug 28, 2025
22 checks passed
@rtimms rtimms deleted the fix-bulk-ocp-hysteresis branch August 28, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants