Composite esoh half cell

[aabills]

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

• No style issues: nox -s pre-commit
• All tests pass: nox -s tests
• The documentation builds: nox -s doctests
• Code is commented for hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.88%. Comparing base (acff2a2) to head (b4d5383).
⚠️ Report is 98 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #5179   +/-   ##
========================================
  Coverage    98.87%   98.88%           
========================================
  Files          320      320           
  Lines        26872    26949   +77     
========================================
+ Hits         26571    26648   +77     
  Misses         301      301           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[rtimms]

Thanks, implementation looks good but I wonder if it is better for the composite model to be a separate class for consistency with the full cell model? Or make the full-cell one into a single class that then calls the standard or composite version based on the options?

[aabills]

Thanks, implementation looks good but I wonder if it is better for the composite model to be a separate class for consistency with the full cell model? Or make the full-cell one into a single class that then calls the standard or composite version based on the options?

I have no preference, let me know what you prefer. The interesting thing about the half cell case is that the composite is just one additional equation that can be solved totally separately, so we can just add an additional model class for that if you want, right now I just do it in an if statement.

[rtimms]

Let's merge as-is for now so as not to overcomplicate things. Later we should unify the esoh code as it is a bit complicated.