Skip to content

Unpin numpy, bump pybammsolvers#5204

Merged
MarcBerliner merged 4 commits intodevelopfrom
unpin-numpy-bump-pybammsolvers-v0.3.0
Sep 18, 2025
Merged

Unpin numpy, bump pybammsolvers#5204
MarcBerliner merged 4 commits intodevelopfrom
unpin-numpy-bump-pybammsolvers-v0.3.0

Conversation

@MarcBerliner
Copy link
Member

Description

Fixes #4183

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

MarcBerliner and others added 3 commits September 18, 2025 12:20
Co-Authored-By: David Straub <10965193+DavidMStraub@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.80%. Comparing base (b4073b4) to head (4a852a7).
⚠️ Report is 88 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5204      +/-   ##
===========================================
- Coverage    98.80%   98.80%   -0.01%     
===========================================
  Files          320      320              
  Lines        27074    27072       -2     
===========================================
- Hits         26750    26748       -2     
  Misses         324      324              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @MarcBerliner! Please let me know when this is ready

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
@MarcBerliner MarcBerliner marked this pull request as ready for review September 18, 2025 16:59
@MarcBerliner MarcBerliner requested a review from a team as a code owner September 18, 2025 16:59
@MarcBerliner MarcBerliner enabled auto-merge (squash) September 18, 2025 17:01
@MarcBerliner MarcBerliner merged commit a72e35d into develop Sep 18, 2025
34 of 38 checks passed
@MarcBerliner MarcBerliner deleted the unpin-numpy-bump-pybammsolvers-v0.3.0 branch September 18, 2025 17:57
@DavidMStraub
Copy link
Contributor

🥳

pipliggins pushed a commit to pipliggins/PyBaMM that referenced this pull request Oct 13, 2025
* Update pyproject.toml

* update docs

* update invalid docs

Co-Authored-By: David Straub <10965193+DavidMStraub@users.noreply.github.com>

* Update pyproject.toml

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>

---------

Co-authored-by: David Straub <10965193+DavidMStraub@users.noreply.github.com>
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compatibility with NumPy v2

3 participants