[Fix] Handle missing geometry keys in latexify for lithium plating mo…#5245
Merged
agriyakhetarpal merged 3 commits intopybamm-team:developfrom Dec 23, 2025
Merged
Conversation
Contributor
Author
|
Hi, this has been open for a while, I would like to get some feedback on this, thanks. |
agriyakhetarpal
previously approved these changes
Dec 19, 2025
Member
agriyakhetarpal
left a comment
There was a problem hiding this comment.
Thanks, @swastim01! Sorry for dropping the ball on this; I just noticed it.
Member
|
Could you please rebase and resolve the conflicts? The failures in the tests have been fixed via #5271. |
agriyakhetarpal
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Fix] Handle missing geometry keys in
latexifyfor lithium plating models (#4218)Description
This PR fixes a
KeyError: 'min'that occurred when usinglatexify()on models with lithium plating (e.g., SPM withoptions={"lithium plating": "irreversible"}).The issue was caused by missing geometry keys (
min/max) during LaTeX equation generation.This change adds safe handling for those missing keys, allowing correct LaTeX output without errors.
Fixes
Fixes #4218
Type of change
Changes Made
"min"and"max"keys inlatexify.pytest_latexify_with_lithium_platingto verify the fixChangelog
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #):
Testing
Checklist