Set initial conditions from y slice

[rtimms]

Description

Set initial conditions from y_slices in set_initial_conditions_from if the model is discretised and the variable is in the state vector for the model and the solution.

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

• No style issues: nox -s pre-commit
• All tests pass: nox -s tests
• The documentation builds: nox -s doctests
• Code is commented for hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[rtimms]

@DrSOKane this fixes the issue you were seeing in #5214. The problem is that in going from one step of the experiment to the next it was trying to create a 4D ProcessedVariable to update the initial conditions, but 4D ProcessedVariables aren't yet supported. This sidesteps the issue by directly getting the state from the statevector.

[codecov]

Codecov Report

❌ Patch coverage is 91.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.76%. Comparing base (24db71a) to head (2da5a60).

Files with missing lines	Patch %	Lines
src/pybamm/models/base_model.py	91.66%	5 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #5257      +/-   ##
===========================================
- Coverage    98.78%   98.76%   -0.02%     
===========================================
  Files          321      321              
  Lines        27642    27693      +51     
===========================================
+ Hits         27305    27352      +47     
- Misses         337      341       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[aabills]

coverage is a bit lacking, but not going to block.

[rtimms]

will fix cov before merging

[SOK-Elysia]

@DrSOKane this fixes the issue you were seeing in #5214. The problem is that in going from one step of the experiment to the next it was trying to create a 4D ProcessedVariable to update the initial conditions, but 4D ProcessedVariables aren't yet supported. This sidesteps the issue by directly getting the state from the statevector.

Thank you, it works!