Skip to content

Plot voltage components bugfix#5270

Merged
BradyPlanden merged 5 commits intopybamm-team:developfrom
Daniel-Nicolae23:plot-voltage-components-bugfix
Nov 12, 2025
Merged

Plot voltage components bugfix#5270
BradyPlanden merged 5 commits intopybamm-team:developfrom
Daniel-Nicolae23:plot-voltage-components-bugfix

Conversation

@Daniel-Nicolae23
Copy link
Contributor

Description

  • Fixes a small bug where the electrode_phases parameter was not passed correctly to pybamm.plot_voltage_components()
  • Updates function docstrings

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@Daniel-Nicolae23 Daniel-Nicolae23 requested a review from a team as a code owner November 11, 2025 12:14
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.76%. Comparing base (24db71a) to head (7c8205d).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5270      +/-   ##
===========================================
- Coverage    98.78%   98.76%   -0.02%     
===========================================
  Files          321      321              
  Lines        27642    27693      +51     
===========================================
+ Hits         27305    27352      +47     
- Misses         337      341       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BradyPlanden BradyPlanden enabled auto-merge (squash) November 12, 2025 09:41
@BradyPlanden BradyPlanden merged commit f427b46 into pybamm-team:develop Nov 12, 2025
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants