Improve battle end detection and handling#634
Merged
Conversation
Enhances detection of battle end states by adding new checks and logic to handle lost battle detection more robustly. Introduces check_if_battle_has_ended and check_for_post_battle_button to confirm battle completion, and updates fight loops to avoid infinite waiting when detection is lost repeatedly.
Refactor the is_bright function and extracted gold/yellow crown detection into a separate is_filled_crown function. Updated the battle detection logic to use both functions, improving clarity and maintainability.
martinmiglio
approved these changes
Jan 31, 2026
Member
martinmiglio
left a comment
martinmiglio
left a comment
There was a problem hiding this comment.
Nice fix! Thanks a lot 🪂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhances detection of battle end states by adding new checks and logic to handle lost battle detection more robustly. Introduces check_if_battle_has_ended and check_for_post_battle_button to confirm battle completion, and updates fight loops to avoid infinite waiting when detection is lost repeatedly.
Testing: