Fix idxmax on DataArray with IntervalIndex coordinates#11301
Open
j-haacker wants to merge 2 commits intopydata:mainfrom
Open
Fix idxmax on DataArray with IntervalIndex coordinates#11301j-haacker wants to merge 2 commits intopydata:mainfrom
j-haacker wants to merge 2 commits intopydata:mainfrom
Conversation
Co-authored-by: Claude <noreply@anthropic.com>
|
Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient. |
Contributor
Author
|
The failing CI shows "39 failed, 1 skipped, 2 warnings". To me the failing tests seem unrelated to the changes. Below one of the 39 similar fails. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a regression in
DataArray.idxmax()forpandas.IntervalIndexcoordinates.On current
main, a simpleIntervalIndex-backedDataArray.idxmax()call raisesTypeError: len() of unsized objectwhile older xarray releases (verified for 2024.11) returned the selected interval label correctly. The failure comes from_calc_idxminmax()rebuilding the coordinate result through the generic variable indexing path, which breaks for extension-array-backed interval coordinates.This PR adds a minimal regression test and applies a narrow fix in
_calc_idxminmax(): for extension-array-backed coordinates, it reconstructs the selected labels directly instead of routing through the broken replacement path. This restores the expectedidxmax()behavior and also fixes the same underlying issue foridxmin().Checklist
.idxmax()fails if coordinates are intervals #11300AI Disclosure