modify double np.hstack to single np.ravel#402
Open
February24-Lee wants to merge 5 commits intopyg-team:masterfrom
Open
modify double np.hstack to single np.ravel#402February24-Lee wants to merge 5 commits intopyg-team:masterfrom
February24-Lee wants to merge 5 commits intopyg-team:masterfrom
Conversation
for more information, see https://pre-commit.ci
Contributor
Author
|
oh, there were something I missed. I will check and re-try to PR |
akihironitta
reviewed
Jan 5, 2025
Member
akihironitta
left a comment
akihironitta
left a comment
There was a problem hiding this comment.
Improving performance in the codebase is always welcome! Let us know if you need any help :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I tested the time with 880,591 x 1 series data,
the running time improved from almost 2.5 seconds to within 1.0 second.
I thought the usage of double np.hstack was for StateType.sequence_numerical. In this case, np.stack will be fine. But if there is something I missed, please let me know.