Skip to content

Expose /all/ run() kwargs in Result/Promise #690

@bitprophet

Description

@bitprophet

This is one of those "could be considered a bugfix, could be considered a feature" things. Follows (kinda) from #682 as that exposed the need/lack here when it created Promise.

tl;dr a subset of run() kwargs are exposed explicitly in Result, such as command, pty etc - but a bunch are not - such as warn, hide, out_stream. It seems like it makes good sense to straight-up copy any and all kwarg values from run into the structures that emerge as Result, as well as Promise (insofar as the "what run did you come from?" property applies to both).

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions