helpers: simplify Uninferable type error message#3010
Merged
DanielNoord merged 1 commit intopylint-dev:mainfrom Mar 21, 2026
Merged
Conversation
38ad36d to
0d6ef31
Compare
Contributor
Author
|
Rebased this PR branch onto current What changed:
Validation run:
|
DanielNoord
approved these changes
Mar 21, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3010 +/- ##
=======================================
Coverage 93.27% 93.27%
=======================================
Files 92 92
Lines 11350 11350
=======================================
Hits 10587 10587
Misses 763 763
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #2760
This simplifies the
AstroidTypeErrorbranch in_object_type_is_subclass.When
klassisUninferable, we already know its exact type from the guard:So the error message no longer needs runtime interpolation via
type(klass).The message is now emitted as a static literal while preserving the same text output.
Validation
python -m pytest tests/brain/test_brain.py -k "isinstance or issubclass"35 passed, 105 deselected