Skip to content

Host of changes for even more cargo blocks #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
LordIdra wants to merge 5 commits into
base: cargo-polishing
Choose a base branch
from
Open

Host of changes for even more cargo blocks #546

LordIdra wants to merge 5 commits into from

Conversation

@LordIdra
Copy link
Contributor

@LordIdra LordIdra commented Jan 1, 2026 •
edited
Loading

  • Add onUnload method to PylonEntity
  • Add crafter compatibility with Pylon recipes (temporary, should be changed later - left a TODO)
  • Add milliseconds unit
  • Add milliseconds to formatDuration
  • Slightly update guide lore with more info
  • Don't set brightness of fluid connection points manually (this looked weird at night and meant the points were very dark and hard to see)
  • Fix styling not being applied to formatDuration result (I don't know if this was intentional? It looks really strange so have changed it regardless)
  • Fix 'duplicate connection point' error (probably)
  • Fix Justin's code

closes #540

@LordIdra LordIdra changed the title Even more cargo blocks Host of changes for even more cargo blocks Jan 1, 2026
@LordIdra LordIdra changed the base branch from more-cargo-blocks to cargo-polishing January 1, 2026 23:27
Seggan
Seggan reviewed Jan 2, 2026
View reviewed changes
Copy link
Member

@Seggan Seggan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise, untested ingame

OhmV-IR
OhmV-IR requested changes Jan 5, 2026
View reviewed changes
Copy link
Contributor

@OhmV-IR OhmV-IR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💀

@LordIdra LordIdra requested a review from OhmV-IR January 5, 2026 22:33
Seggan
Seggan approved these changes Jan 5, 2026
View reviewed changes
Copy link
Member

@Seggan Seggan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not my 💀! :despair:

OhmV-IR
OhmV-IR approved these changes Jan 5, 2026
View reviewed changes
Copy link
Contributor

@OhmV-IR OhmV-IR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Seggan Seggan Seggan approved these changes

@OhmV-IR OhmV-IR OhmV-IR approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LordIdra @Seggan @OhmV-IR